Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,test: fix spelling in comments #18018

Closed
wants to merge 3 commits into from
Closed

lib,test: fix spelling in comments #18018

wants to merge 3 commits into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jan 6, 2018 •
edited
Loading

Various spelling fixes. I am not sure whether to split this into multiple commits.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, test

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jan 6, 2018
maclover7
maclover7 approved these changes Jan 6, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Personally, I'm fine with one large commit.

@tniessen tniessen changed the title test: fix spelling in test case comments lib,test: fix spelling in test case comments Jan 6, 2018
@tniessen tniessen changed the title lib,test: fix spelling in test case comments lib,test: fix spelling in comments Jan 6, 2018
apapirovski
apapirovski approved these changes Jan 6, 2018
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! 👍

test/parallel/test-http-agent-keepalive.js Outdated
@@ -102,7 +102,7 @@ function remoteClose() {
}

function remoteError() {
// remove server will destroy ths socket
// remove server will destroy the socket
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "remove" here is supposed to be "remote"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yeah sure, thanks!

test/parallel/test-http-extra-response.js Outdated
@@ -51,7 +51,7 @@ const server = net.createServer(function(socket) {

if (postBody.includes('\r\n')) {
socket.write(fullResponse);
// omg, I wrote the response twice, what a terrible HTTP server I am.
// I wrote the response twice, what a terrible HTTP server I am.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this comment adds much in general, to be honest. I would be in favour of taking it out.

test/parallel/test-promises-unhandled-rejections.js Outdated
@@ -293,7 +293,7 @@ asyncTest('While inside setImmediate, catching a rejected promise derived ' +
});
});

// State adapation tests
// State adaption tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what this comment is saying (before or after). :( I think the tests describe what they do well enough.

(If we are to keep it, I would prefer to use the more common version "adaptation".)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand that test either, I went with "adaptation" for now. If someone knows what's going on here, we might actually remove it.

@tniessen
Copy link
Member Author

tniessen commented Jan 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12438/

@jasnell
Copy link
Member

jasnell commented Jan 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12472/

@tniessen
Copy link
Member Author

Seems like CI was interrupted, new CI: https://ci.nodejs.org/job/node-test-pull-request/12494/

tniessen added a commit that referenced this pull request Jan 11, 2018
@tniessen
test: fix spelling in test case comments
e890344 
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
tniessen added a commit that referenced this pull request Jan 11, 2018
@tniessen
lib: fix spelling in comments
ba07699 
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@tniessen
Copy link
Member Author

Landed in e890344, ba07699.

@tniessen tniessen closed this Jan 11, 2018
@AndreasMadsen AndreasMadsen removed the async_hooks Issues and PRs related to the async hooks subsystem. label Jan 16, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@tniessen @evanlucas
test: fix spelling in test case comments
5fccb6e 
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@tniessen @evanlucas
lib: fix spelling in comments
dcdb646 
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging or v8.x-staging?? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
@tniessen
test: fix spelling in test case comments
dbf0618 
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
@tniessen
lib: fix spelling in comments
e335b55 
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
@tniessen
test: fix spelling in test case comments
8a95359 
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Mar 14, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
894b179 
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
a52f4eb 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@tniessen @MylesBorins
lib: fix spelling in comments
8cbb164 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
1196355 
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
059a803 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen @MylesBorins
lib: fix spelling in comments
63b0de2 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
502781c 
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen @MylesBorins
test: fix spelling in test case comments
1043b6f 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen @MylesBorins
lib: fix spelling in comments
3df0570 
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@hiroppy hiroppy hiroppy approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.