Flaky test-cluster-http-pipe

[joyeecheung]

• Version: master
• Platform: ubuntu
• Subsystem: test

Sample

not ok 246 parallel/test-cluster-http-pipe
  ---
  duration_ms: 0.516
  severity: fail
  stack: |-
    Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
        at Object.exports.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1404-64/test/common/index.js:488:10)
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1404-64/test/parallel/test-cluster-http-pipe.js:37:31)
        at Module._compile (module.js:607:30)
        at Object.Module._extensions..js (module.js:618:10)
        at Module.load (module.js:526:32)
        at tryModuleLoad (module.js:489:12)
        at Function.Module._load (module.js:481:3)
        at Function.Module.runMain (module.js:648:10)
        at startup (bootstrap_node.js:191:16)
    events.js:195
          throw er; // Unhandled 'error' event
          ^
    
    Error: bind EADDRINUSE ../../../../../node-tmp/tmp.0node-test.30586.sock
        at Object._errnoException (util.js:1023:13)
        at _exceptionWithHostPort (util.js:1044:20)
        at listenOnMasterHandle (net.js:1417:16)
        at rr (internal/cluster/child.js:111:12)
        at Worker.send (internal/cluster/child.js:78:7)
        at process.onInternalMessage (internal/cluster/utils.js:42:8)
        at emitTwo (events.js:141:20)
        at process.emit (events.js:227:7)
        at emit (internal/child_process.js:790:12)
        at _combinedTickCallback (internal/process/next_tick.js:141:11)
  ...

I think we should migrate all those listen(common.PIPE) usage to listening on random pipes as what we did for common.PORT...thoguhts? @nodejs/testing

[apapirovski]

Seen it fail a number of times lately (and in general, tests with common.PIPE seem to show up here and there). +1 from me.

[gibfahn]

I think we should migrate all those listen(common.PIPE) usage to listening on random pipes as what we did for common.PORT...thoughts? @nodejs/testing

SGTM, I guess we just could change common.PIPE to include the test name in the pipe name.

node/test/common/index.js

Lines 273 to 278 in bf1bace

	{
	const localRelative = path.relative(process.cwd(), `${exports.tmpDir}/`);
	const pipePrefix = exports.isWindows ? '\\\\.\\pipe\\' : localRelative;
	const pipeName = `node-test.${process.pid}.sock`;
	exports.PIPE = pipePrefix + pipeName;
	}

[Trott]

Random pipe names are not needed. The problem is that the pipes are being created in test rathe than in the appropriate temp directory inside test due to a bug in common.PIPE instroduced in c34ae48. Fix coming soon.

[Trott]

Should be fixed by #16364 I think,