Skip to content

Commit

Permalink
test: fix common.PIPE path bug
Browse files Browse the repository at this point in the history
`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.

The bug in `common.PIPE` was introduced in
c34ae48.

PR-URL: #16364
Fixes: #16290
Fixes: #16323
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
  • Loading branch information
Trott authored and MylesBorins committed Oct 23, 2017
1 parent 598787d commit b1c7889
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ Object.defineProperty(exports, 'hasFipsCrypto', {
const localRelative = path.relative(process.cwd(), `${exports.tmpDir}/`);
const pipePrefix = exports.isWindows ? '\\\\.\\pipe\\' : localRelative;
const pipeName = `node-test.${process.pid}.sock`;
exports.PIPE = pipePrefix + pipeName;
exports.PIPE = path.join(pipePrefix, pipeName);
}

{
Expand Down

0 comments on commit b1c7889

Please sign in to comment.