Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky async-hooks/test-pipeconnectwrap #16290

Closed
joyeecheung opened this issue Oct 18, 2017 · 5 comments
Closed

Flaky async-hooks/test-pipeconnectwrap #16290

joyeecheung opened this issue Oct 18, 2017 · 5 comments
Labels
async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Oct 18, 2017 •
edited
Loading

  • Version: master
  • Platform: fedora22
  • Subsystem: test, async-hooks

I believe I have seen more than one failures this week, looks like some common.PIPE conflicts. Sample

not ok 1743 async-hooks/test-pipeconnectwrap
  ---
  duration_ms: 0.217
  severity: fail
  stack: |-
    events.js:195
          throw er; // Unhandled 'error' event
          ^
    
    Error: listen EADDRINUSE ../../../../../node-tmp/tmp.1node-test.15762.sock
        at Object._errnoException (util.js:1023:13)
        at _exceptionWithHostPort (util.js:1044:20)
        at Server.setupListenHandle [as _listen2] (net.js:1340:19)
        at listenInCluster (net.js:1398:12)
        at Server.listen (net.js:1497:5)
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora22/test/async-hooks/test-pipeconnectwrap.js:22:5)
        at Module._compile (module.js:601:30)
        at Object.Module._extensions..js (module.js:612:10)
        at Module.load (module.js:520:32)
        at tryModuleLoad (module.js:483:12)
@joyeecheung joyeecheung added async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Oct 18, 2017
@joyeecheung
Copy link
Member Author

cc @nodejs/testing @nodejs/async_hooks

@joyeecheung joyeecheung mentioned this issue Oct 19, 2017
Closed
3 tasks
@Trott
Copy link
Member

Trott commented Oct 21, 2017

Looks like it's being opened in the wrong directory. The path should be something more like ../../../../../node-tmp/tmp.1/node-test.15762.sock rather than ending in tmp.1node-test.15762.sock. Basically, there's a missing slash. So it's not in the tmp directory (in this case tmp.1). Which means that it won't get removed by common.refreshTmpDir(). Which may be the source of the conflict/issue.

Looks like maybe a bug in common.PIPE?

@Trott
Copy link
Member

Trott commented Oct 21, 2017

Yeah, it's a bug in common.PIPE. Fix coming momentarily.

Trott added a commit to Trott/io.js that referenced this issue Oct 21, 2017
@Trott
test: fix common.PIPE path bug
83b40de 
`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.

The bug in `common.PIPE` was introduced in
c34ae48.

Fixes: nodejs#16290
Fixes: nodejs#16323
@Trott Trott mentioned this issue Oct 21, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Oct 21, 2017

Should be fixed by #16364

@Trott Trott closed this as completed in 8e268c7 Oct 21, 2017
@refack
Copy link
Contributor

refack commented Oct 22, 2017

The gestalt effect strikes again. 4 out of 5 people would not have seen that. Well done.

MylesBorins pushed a commit that referenced this issue Oct 23, 2017
@Trott @MylesBorins
test: fix common.PIPE path bug
b1c7889 
`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.

The bug in `common.PIPE` was introduced in
c34ae48.

PR-URL: #16364
Fixes: #16290
Fixes: #16323
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 26, 2017
@Trott @addaleax
test: fix common.PIPE path bug
aa53fde 
`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.

The bug in `common.PIPE` was introduced in
c34ae48.

PR-URL: nodejs/node#16364
Fixes: nodejs/node#16290
Fixes: nodejs/node#16323
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this issue Dec 7, 2017
@Trott @addaleax
test: fix common.PIPE path bug
3aeb866 
`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.

The bug in `common.PIPE` was introduced in
c34ae48.

PR-URL: nodejs/node#16364
Fixes: nodejs/node#16290
Fixes: nodejs/node#16323
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix common.PIPE path bug Trott/io.js
3 participants
@refack @Trott @joyeecheung