Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): Added FormField, its subcomponents and FormFieldTextbox #306

Merged
merged 18 commits into from
Nov 8, 2024

Conversation

VladAfanasev
Copy link
Contributor

Let op:
Dit is een nieuwe branch t.o.v. main omdat de rebase niet lukte.
Form Field Label is al gereviewd in de vorige branch.

Contents

De volgende componenten toegevoegd:

  • Form Field Text Input
  • Form Field Label (Feedback is al verwerkt)

Checklist

  • New features/components and bugfixes are covered by tests
  • Changesets are created
  • Definition of Done is checked

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 3:06pm

@MrSkippy
Copy link
Contributor

MrSkippy commented Oct 23, 2024

@VladAfanasev Nog twee build fixes:

Error: packages/components-react lint: src/index.ts(13,29): error TS2724: '"./form-field/FormField"' has no exported member named 'LuxFormFieldProps'.

en een van de testen faalt nog.

@MrSkippy MrSkippy requested a review from rwittenberns November 7, 2024 14:57
@MrSkippy MrSkippy changed the title feat: added form field text input and label component feat(react): Added FormField, its subcomponents and FormFieldTextbox Nov 8, 2024
@MrSkippy MrSkippy merged commit 2ac36c4 into main Nov 8, 2024
12 checks passed
@MrSkippy MrSkippy deleted the react-components/form-field branch November 8, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form field description [Form Field] Text Input Form field label Form field error message Form field
2 participants