Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form field #232

Closed
8 tasks
MrSkippy opened this issue Sep 23, 2024 · 1 comment · Fixed by #306
Closed
8 tasks

Form field #232

MrSkippy opened this issue Sep 23, 2024 · 1 comment · Fixed by #306
Assignees
Labels
new component Adding a new component to the library react Issue involving a ReactJS component

Comments

@MrSkippy
Copy link
Contributor

MrSkippy commented Sep 23, 2024

Form Field bestaat uit:

Definition of done

Component

  • Component is beschikbaar in de index
  • Design tokens worden gebruikt

Storybook

  • Playground story
  • States en properties stories
  • Korte beschrijving van het component
    • Wat doet het
    • Basis van het component (bijv Utrecht)
    • Aanpassingen en/of uitbreidingen
    • Relatie met andere componenten (bijv. Form field label en Form field)

Tests

  • Het component rendert
  • Aanpassingen en/of uitbreidingen werken (zie ook Testing components)
  • Visual regression test (door LUX)

Links

Component: https://www.nldesignsystem.nl/form-field
Figma NLDS: https://www.figma.com/design/jzxqJv4PtgHJdmOJwY6lYg/NLDS---Bibliotheek---LUX-tokens?node-id=958-1925
Utrecht component: https://nl-design-system.github.io/utrecht/storybook/?path=/docs/css_css-form-field--docs

@MrSkippy MrSkippy converted this from a draft issue Sep 23, 2024
@MrSkippy MrSkippy added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Sep 23, 2024
@MrSkippy MrSkippy changed the title Input Field Form field Sep 24, 2024
@rwittenberns
Copy link
Contributor

Gewenste feature: error message boven EN onder form field kunnen plaatsen (omdat Logius vooral onder gebruikt en mogelijk later naar boven verplaatst moet worden ivm NLDS best practice).
In NLDS community dev channel discussie starten of dit bij Utrecht toegepast kan worden.

@MrSkippy MrSkippy added new component Adding a new component to the library react Issue involving a ReactJS component labels Oct 1, 2024
@remypar5 remypar5 removed their assignment Oct 8, 2024
@VladAfanasev VladAfanasev self-assigned this Oct 9, 2024
@MrSkippy MrSkippy linked a pull request Oct 21, 2024 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this from In code review to Done in Lux React Components Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component Adding a new component to the library react Issue involving a ReactJS component
Projects
Status: Done
4 participants