Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form field label #241

Closed
3 of 8 tasks
MrSkippy opened this issue Sep 24, 2024 · 2 comments · Fixed by #306
Closed
3 of 8 tasks

Form field label #241

MrSkippy opened this issue Sep 24, 2024 · 2 comments · Fixed by #306
Assignees
Labels
new component Adding a new component to the library react Issue involving a ReactJS component

Comments

@MrSkippy
Copy link
Contributor

MrSkippy commented Sep 24, 2024

Aanpak

utrecht form-label component

Definition of done

Component

  • Component is beschikbaar in de index
  • Design tokens worden gebruikt

Storybook

  • Playground story
  • States en properties stories
  • Korte beschrijving van het component
    • Wat doet het
    • Basis van het component (bijv Utrecht)
    • Aanpassingen en/of uitbreidingen
    • Relatie met andere componenten (bijv. Form field label en Form field)

Tests

  • Het component rendert
  • Aanpassingen en/of uitbreidingen werken (zie ook Testing components)
  • Visual regression test (door LUX)

Links

NLDS

LUX

@MrSkippy MrSkippy converted this from a draft issue Sep 24, 2024
@rwittenberns
Copy link
Contributor

Onderzoeken/bespreken in de NLDS community hoe we omgaan met niet-verplichte velden. Impact op aria-labels en bv meertalig

@MrSkippy MrSkippy mentioned this issue Oct 1, 2024
8 tasks
@MrSkippy MrSkippy added new component Adding a new component to the library react Issue involving a ReactJS component labels Oct 1, 2024
@VladAfanasev VladAfanasev self-assigned this Oct 9, 2024
@MrSkippy MrSkippy linked a pull request Oct 21, 2024 that will close this issue
3 tasks
@AlineNap
Copy link
Contributor

AlineNap commented Nov 6, 2024

Design review 6 November

Component

  1. De type checkbox en radio zouden regular moeten zijn ipv bold. Hiervoor zijn de tokens: utrecht.form-label.checkbox.font-weight en utrecht.form-label.radio.font-weight.

Documentatie

  1. Is het mogelijk dat wij de checked variant uit de playground, voorbeelden en documentatie halen? Wij gebruiken die niet echt, als in hebben geen andere stijling.
  2. Hier heet iets content en maar op andere plekken zie ik children, zit hier een verschil in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component Adding a new component to the library react Issue involving a ReactJS component
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants