NJOY2016.68 #264
Merged
NJOY2016.68 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/mubar
Updating workflow
… RECONR if we have processed MF12 sections (LO=1 only)
This fixes a NJOY crash when performing a CCCR run with interface file DLAYXS selected.
Fix uninitialized array index in CCCR
GROUPR writes gendf data in a compact way and let us know, what the offset is. The dlayxs part of CCCR loops over the full energy group range in container variable `a` where it should loop only until the offset. Thereby, on chance uninitialized or invalid memory may be addressed and may lead at best to a crash or simply runs without error but resulting in values like 1.E+44 for delayed spectra. This commit introduces the offset and corrects 2 loops. Moreover, a check is introduced if the requested memory fits into the `a` variable. The `a` size variable `isiza` was moved to a parameter statement and renamed to account for 4 byte and 8 byte equivalence'd variables.
* Get low energy offset the NJOY way * Let last loop in `subroutine dldata` go over full `ngn` (error introduced during this PR)
Fix wrong memory addresses due to not accounted GROUPR offset
Fix/groupr mf10
Fix/acer temp
Adding a test for the CCCCR issue
nathangibson14
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes a number of minor issues:
tempd#250).tempd#250. Previously it could happen that ACER picked the wrong temperature from a multi-temperature PENDF file when the materials in the PENDF only contained linearised MF3 data (no MF10, MF12 or MF23 data was added by RECONR).