Fix/mubar #251
Merged
Fix/mubar #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Debug tests seem to fail on test 74 because of a division by zero (not introduced by the mubar change). Goes to show how little we actually cover in all our tests. I corrected the issue and am now waiting for the CI to finish running before approving the PR. |
whaeck
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing ACEtk uncovered an indexing issue in ACER calculation of inelastic thermal mubar for IFENG=2 ACE files. These changes correct this issue and test its accuracy. The inelastic thermal mubar values in question were tested (Test 74) were independently calculated and verified using Python (ACEtk).
