Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add _graph_checksums to input_spec if missing #584

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

NicolasGensollen
Copy link
Contributor

@NicolasGensollen NicolasGensollen commented Sep 26, 2022

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Following #573, this PR proposes to automatically add _graph_checksums to the input_spec provided to the workflow when these specifications are provided directly as a SpecInfo instance.
This is already done automatically when input_spec is provided as a list of strings.
This PR also proposes to put the input sanitization code in a separate helper function.

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 77.13% // Head: 76.76% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (a7374aa) compared to base (67f7e72).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   77.13%   76.76%   -0.37%     
==========================================
  Files          20       19       -1     
  Lines        4330     4313      -17     
  Branches     1217     1215       -2     
==========================================
- Hits         3340     3311      -29     
- Misses        802      813      +11     
- Partials      188      189       +1     
Flag Coverage Δ
unittests 76.69% <91.66%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/core.py 89.28% <91.66%> (+0.20%) ⬆️
pydra/utils/profiler.py 38.16% <0.00%> (-5.35%) ⬇️
pydra/engine/helpers.py 78.72% <0.00%> (-1.19%) ⬇️
pydra/engine/task.py 86.15% <0.00%> (-0.62%) ⬇️
pydra/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NicolasGensollen NicolasGensollen marked this pull request as ready for review September 26, 2022 10:25
@satra satra merged commit 8c8a79c into nipype:master Sep 28, 2022
@NicolasGensollen NicolasGensollen deleted the add-graph-checksums-if-missing branch September 28, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants