Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Enable Workflow constructor to receive SpecInfo objects for input_spec parameter #573

Merged

Conversation

NicolasGensollen
Copy link
Contributor

@NicolasGensollen NicolasGensollen commented Sep 1, 2022

Fixes #572

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

This PR adds the possibility to pass an instance of SpecInfo to the Workflow constructor as is already documented. Prior to this PR, passing such input was triggering a TypeError (see #572).

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 77.06% // Head: 77.08% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (0c77ad5) compared to base (219c721).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   77.06%   77.08%   +0.02%     
==========================================
  Files          20       20              
  Lines        4316     4320       +4     
  Branches     1213     1215       +2     
==========================================
+ Hits         3326     3330       +4     
  Misses        802      802              
  Partials      188      188              
Flag Coverage Δ
unittests 76.99% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/core.py 89.04% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NicolasGensollen NicolasGensollen marked this pull request as ready for review September 1, 2022 14:10
@satra satra merged commit 86671ad into nipype:master Sep 1, 2022
@NicolasGensollen NicolasGensollen deleted the fix-SpecInfo-in-Worflow-constructor branch September 2, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow constructor raises TypeError when input_spec is an instance of SpecInfo
2 participants