-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Refactor BIDS and CAPS reader configurations #752
[REF] Refactor BIDS and CAPS reader configurations #752
Conversation
@@ -126,11 +150,7 @@ def add_input_task( | |||
Workflow | |||
An BIDS/CAPS reader based workflow. | |||
""" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this function stands, the task added is hard-coded to be a "reader task". Maybe we can move l.153 to add_input_reading_task
and make this function more generic in case we need to add another "input task" such as a provenance task.
52e0bd1 simplifies the input specifications (no need to specify the |
Hi @NicolasGensollen, thanks for this PR ! there seems to be a couple of unit tests that need updating. |
758cba9
to
6c17d26
Compare
Thanks @NicolasGensollen ! The code LGTM. If no pydra release is planned we can add the dev dependency and merge. |
We could add it now, check that CI passes, and later update |
Ok fair enough, I'll merge. |
This PR proposes to refactor the BIDS (see #658) and CAPS (see #731) reader configurations. More precisely, this PR attempts to:
Another reason, which originally motivated this refactoring is that we will pretty soon have to provide more complex BIDS input specifications than simple strings (as it is currently the case for
t1-linear
withT1W
).For example, in
PETVolume
(see #729), we need to read PET scans as inputs, but the user specifies through the CLI the tracer of interest. This means that we need to be able to dynamically pass this information to the querying engine, and not rely on static predefined queries, otherwise we will end up pretty soon with un-maintainable query registries like this: