ENH: Add DWI shell detection utils #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
AddShellDetectionUtils
branch
from
971ba60
to
e1fdf25
Compare
jhlegarreta
force-pushed
the
AddShellDetectionUtils
branch
2 times, most recently
from
f971213
to
78cd5d6
Compare
|
@oesteban We may need this at some point. Ready to be merged. |
jhlegarreta
force-pushed
the
AddShellDetectionUtils
branch
from
78cd5d6
to
9d2bf44
Compare
oesteban
reviewed
Jun 7, 2024
jhlegarreta
force-pushed
the
AddShellDetectionUtils
branch
from
9d2bf44
to
9c894d3
Compare
oesteban
reviewed
Jun 8, 2024
oesteban
approved these changes
Jun 8, 2024
oesteban
previously approved these changes
Jun 8, 2024
Add DWI shell detection utils. Add the corresponding tests and some actual test data files.
jhlegarreta
force-pushed
the
AddShellDetectionUtils
branch
from
9c894d3
to
b41a427
Compare
oesteban
reviewed
Jun 8, 2024
oesteban
reviewed
Jun 10, 2024
Prefer capping b-values to a sensible maximum default value to make the binning strategy more robust. Raise a `ValueError` users when no actual shells are found. Return the median estimated b-vals for each bin. Co-authored-by: Oscar Esteban <[email protected]>
jhlegarreta
force-pushed
the
AddShellDetectionUtils
branch
from
7f5d46a
to
d221f03
Compare
oesteban
approved these changes
Jun 12, 2024
|
I think this is ready! thanks a ton! Please merge if you think all is okay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DWI shell detection utils.
Add the corresponding tests.