-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement gaussian process #1
ENH: Implement gaussian process #1
Conversation
Implement Gaussian Process.
4cf167a
to
2234d06
Compare
cb948c1
to
663e859
Compare
2234d06
to
c7c91fc
Compare
c7c91fc
to
af28a0a
Compare
af28a0a
to
beb0839
Compare
@yibeichan @jhlegarreta how much of this can be split into smaller chunks and merged into the PR's branch? |
On my ToDo list. The angle matrix computation part has been answered in PR nipreps#200. I will have a look at the other suggestions as time permits. Given that we decided to split the whole GP draft PR into smaller patch sets for easier review and integration (e.g. nipreps#198, nipreps#199, nipreps#200, and upcoming ones) I will need to cherry pick the remaining suggestions in her. |
Went through Yibei's changes on the single-shell covariance matrix computation and comments on the multi-shell case:
So closing. Thanks for the work @yibeichan. |
calculate_angle_matrix
by adding more checks for the input types and the dimensionscompute_single_shell_covariance_matrix
by (a) removingk
from inputs and (b) callingcompute_spherical_function
in the calculationnotes: if we remove
k
in the input for the single shell, we probably want to be consistent and do it for multiple shell too