Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement gaussian process #1

Conversation

yibeichan
Copy link

@yibeichan yibeichan commented May 16, 2024

  1. improve calculate_angle_matrix by adding more checks for the input types and the dimensions
  2. update compute_single_shell_covariance_matrix by (a) removing k from inputs and (b) calling compute_spherical_function in the calculation

notes: if we remove k in the input for the single shell, we probably want to be consistent and do it for multiple shell too

Implement Gaussian Process.
@oesteban
Copy link

@yibeichan @jhlegarreta how much of this can be split into smaller chunks and merged into the PR's branch?

@jhlegarreta
Copy link
Owner

On my ToDo list. The angle matrix computation part has been answered in PR nipreps#200.

I will have a look at the other suggestions as time permits. Given that we decided to split the whole GP draft PR into smaller patch sets for easier review and integration (e.g. nipreps#198, nipreps#199, nipreps#200, and upcoming ones) I will need to cherry pick the remaining suggestions in her.

@jhlegarreta
Copy link
Owner

Went through Yibei's changes on the single-shell covariance matrix computation and comments on the multi-shell case:

So closing.

Thanks for the work @yibeichan.

@jhlegarreta jhlegarreta closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants