Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cypress): Splits selectors into multiple files #677

Merged
merged 4 commits into from
Jul 19, 2019

Conversation

justin-bits
Copy link
Collaborator

@justin-bits justin-bits commented Jul 16, 2019

Resolves #580

  • Some performance changes to reduce flaky tests and produce a cleaner pattern to follow when using image comparisons
  • selectors.js is now multiple files
  • The structure of the selectors were modified to reduce the complexity and length. This results in shorter lines in tests and selectors that are easier to lookup. There was also a significant reduction of duplicate selectors. Dropped the use of _WILDCARD.
  • Updates to images as workaround for Default icon for features imported via kml is now a push pin #676
  • Significant rework/additions to feature-list.spec.js (which was renamed from layer-features.spec.js to more closely match the terminology used in the application). Some work from Expand test coverage for Feature List dialog #581 completed with this PR.
  • Inclusion of workaround for Context menus not always opening from grids #667
  • toolbar-right.spec.js now has its own test data
  • Added support for running any test case (or group of test cases) in a batch five times in a row to check for flaky tests during test development
  • Handles specific console errors that started being thrown by OS. @jsalankey indicated these specific errors are okay to disregard.
  • Removed test selectors from OS as substitutes were identified
  • Feature size rendering inconsistencies #678 and Tests with ArcGIS state file intermittently failing #680 filed as known issues with the current version of tests/OS

Copy link
Collaborator

@bradh bradh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the 0] file?

@justin-bits
Copy link
Collaborator Author

@bradh, oops! I just removed it. Good catch.

@schmidtk
Copy link
Contributor

The outerWidth console error will still be present until #691 is merged.

@schmidtk schmidtk merged commit 1e3e8ca into ngageoint:master Jul 19, 2019
@justin-bits justin-bits deleted the test/refactor-selectors branch July 20, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Cypress selectors
3 participants