Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cypress selectors #580

Closed
justin-bits opened this issue May 31, 2019 · 5 comments · Fixed by #677
Closed

Refactor Cypress selectors #580

justin-bits opened this issue May 31, 2019 · 5 comments · Fixed by #677
Assignees
@justin-bits
Labels
cypress tests

Comments

@justin-bits
Copy link
Collaborator

justin-bits commented May 31, 2019 •
edited
Loading

#567 (comment)

  • Break selectors.js into multiple files
  • Create generic selectors for commonly used elements (e.g OK button)
  • Update tests accordingly to reference updated selectors
@justin-bits justin-bits mentioned this issue May 31, 2019
Merged
justin-bits added a commit to justin-bits/opensphere that referenced this issue Jun 17, 2019
@justin-bits
test(cypress): Removed references to menuOptions
e935a31 
ngageoint#580
justin-bits added a commit to justin-bits/opensphere that referenced this issue Jun 18, 2019
@justin-bits
test(cypress): Removed references to menuOptions
01afddc 
ngageoint#580
@justin-bits
Copy link
Collaborator Author

This is in progress here: https://github.com/justin-bits/opensphere/tree/test/refactor-selectors

@justin-bits
Copy link
Collaborator Author

Fixes that were in #622 and #623 are included in the work for this branch.

@justin-bits justin-bits changed the title Refactor Cypress selectors, update tests to use .within Refactor Cypress selectors Jul 9, 2019
@justin-bits
Copy link
Collaborator Author

PR #677

@justin-bits justin-bits mentioned this issue Jul 16, 2019
Merged
@bradh
Copy link
Collaborator

bradh commented Jul 17, 2019

When we originally discussed this, I thought the approach was that selectors that are only used in a single test set would be kept with the using code. Did that change?

@justin-bits
Copy link
Collaborator Author

Selectors are generally all expected to be used by more than one spec file and should be shared.

In this case, additional spec files will eventually be created for testing with other types of data and multiple instances of the dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justin-bits justin-bits

Labels
cypress tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(cypress): Splits selectors into multiple files justin-bits/opensphere
3 participants
@bradh @wallw-teal @justin-bits