Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meryl count and meryl histogram migration to nf-test #5401

Merged
merged 16 commits into from
Mar 27, 2024

Conversation

mahesh-panchal
Copy link
Member

PR checklist

  • Adds k-value as mandatory parameter to meryl/count and meryl/histogram
  • Migrates pytest to nf-test
  • Adds kvalue to genomescope2 nf-test

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mahesh-panchal mahesh-panchal requested a review from a team as a code owner March 26, 2024 20:44
@mahesh-panchal mahesh-panchal requested review from Aratz and rodtheo and removed request for a team March 26, 2024 20:44
@mahesh-panchal mahesh-panchal changed the title Meryl count and merly histogram migration to nf-test Meryl count and meryl histogram migration to nf-test Mar 26, 2024
Copy link
Contributor

@rodtheo rodtheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding! Thanks for updating these modules and corresponding tests.

@mahesh-panchal mahesh-panchal added this pull request to the merge queue Mar 27, 2024
Merged via the queue into nf-core:master with commit c95215b Mar 27, 2024
19 checks passed
@mahesh-panchal mahesh-panchal deleted the meryl_count_nftest branch March 27, 2024 05:08
jvfe added a commit that referenced this pull request Mar 27, 2024
* master:
  Migrate meryl unionsum nftest (#5404)
  Adding Fast epistasis module  (#5389)
  corrected bug in asereadcounter (#5403)
  Meryl count and meryl histogram migration to nf-test (#5401)
@GallVp
Copy link
Member

GallVp commented May 21, 2024

Hey guys!

Thanks for this module. Is there a reason the memory= parameter (marbl/meryl#24 (comment)) wasn't added? Should I add it and create a PR?

@mahesh-panchal
Copy link
Member Author

Oversight perhaps, but is there a need to limit memory? Is it behaving badly on your systems? If it's not an issue I would just let it use what it can get a hold of, but if you see a need for it, make a PR

@GallVp
Copy link
Member

GallVp commented May 21, 2024

It can be an issue because by default it uses all the available system memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants