New attempt to add merfin/hist module

[rodtheo]

PR checklist

Closes #5136

• This PR implements the module merfin/hist. Its a new attempt after incorporating suggestions mentioned in merfin_hist module added #5300.
• If you've fixed a bug or added code that should be tested, add tests!
• If you've added a new tool - have you followed the module conventions in the contribution docs
• If necessary, include test data in your PR.
• Remove all TODO statements.
• Emit the versions.yml file.
• Follow the naming conventions.
• Follow the parameters requirements.
• Follow the input/output options guidelines.
• Add a resource label
• Use BioConda and BioContainers if possible to fulfil software requirements.
• Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
  • For modules:
    • nf-core modules test <MODULE> --profile docker
    • nf-core modules test <MODULE> --profile singularity
    • nf-core modules test <MODULE> --profile conda
  • For subworkflows:
    • nf-core subworkflows test <SUBWORKFLOW> --profile docker
    • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
    • nf-core subworkflows test <SUBWORKFLOW> --profile conda

[rodtheo]

@itrujnara, any chances to review it again? Thanks for considering my request.

[itrujnara]

Nice! Stub test is missing, otherwise looks good.

[itrujnara]

The new modules looks good now. I was puzzled by the random changes to other modules, but I assume these are for the stub test and thus relevant. Merge at your discretion.

[mahesh-panchal]

Thanks for updating the stubs

[rodtheo]

Thanks for updating the stubs

I'm glade to contribute! However I'm still getting an error related to genomescope2 running tests in conda environment. Any tips on why this is happening?

[mahesh-panchal]

Thanks for updating the stubs

I'm glade to contribute! However I'm still getting an error related to genomescope2 running tests in conda environment. Any tips on why this is happening?

I'm not entirely clear, but I'm going to make a PR to your branch at some point in the coming days to try and fix the test.

[mahesh-panchal]

Requesting changes to remove the hack. The module itself should have been corrected first rather than add a hack to the module test. My apologies for not picking this up earlier.

See #5399 for the updated module PR for Genomescope2

[mahesh-panchal]

#5401 should also remove the need to have the fixes for the linting checks here.
You've been added as co-author on the relevant commits in those other PRs.

[mahesh-panchal]

Aside from styling, there's a few things to clean up still and one thing to investigate.

[mahesh-panchal]

Nice work. Thank you. Sorry about all the changes.

[rodtheo]

Nice work. Thank you. Sorry about all the changes.

No worries, thank you for your valuable tips and suggestions. I've learned a lot.