Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Fast epistasis module #5389

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Adding Fast epistasis module #5389

merged 5 commits into from
Mar 27, 2024

Conversation

DavideBag
Copy link
Contributor

PR checklist

  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@DavideBag DavideBag requested a review from lescai March 26, 2024 09:08
@DavideBag DavideBag self-assigned this Mar 26, 2024
@DavideBag DavideBag requested a review from a team as a code owner March 26, 2024 09:08
@DavideBag DavideBag requested review from leoisl and removed request for a team March 26, 2024 09:08
lescai
lescai requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@lescai lescai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor indent alignment with option:true
otherwise looks good

modules/nf-core/plink/fastepistasis/main.nf Outdated Show resolved Hide resolved
lescai
lescai approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@lescai lescai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now thanks

@lescai lescai added this pull request to the merge queue Mar 27, 2024
Merged via the queue into nf-core:master with commit a3501bc Mar 27, 2024
11 checks passed
jvfe added a commit that referenced this pull request Mar 27, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
251f94d 
* master:
  Migrate meryl unionsum nftest (#5404)
  Adding Fast epistasis module  (#5389)
  corrected bug in asereadcounter (#5403)
  Meryl count and meryl histogram migration to nf-test (#5401)
@DavideBag DavideBag deleted the fast_epistasis branch April 3, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lescai lescai lescai approved these changes

@leoisl leoisl Awaiting requested review from leoisl leoisl was automatically assigned from nf-core/nf-test

Assignees

@DavideBag DavideBag

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideBag @lescai