Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added contrast limited adaptive histogram equalization module #5268

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Added contrast limited adaptive histogram equalization module #5268

merged 8 commits into from
Mar 20, 2024

Conversation

kbestak
Copy link
Contributor

@kbestak kbestak commented Mar 19, 2024

Based on the Molkart local script with the same functionality. Scikit-image function; pyramidal output file.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements. // not possible
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@kbestak kbestak requested a review from FloWuenne March 19, 2024 15:04
@kbestak kbestak requested a review from a team as a code owner March 19, 2024 15:04
@kbestak kbestak requested review from leoisl and removed request for a team March 19, 2024 15:04
@kbestak
Copy link
Contributor Author

kbestak commented Mar 19, 2024

TODO: exclude module from conda testing; understand issue with linting

@kbestak
Copy link
Contributor Author

kbestak commented Mar 20, 2024

Thank you @FloWuenne !

FloWuenne
FloWuenne reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@FloWuenne FloWuenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

migueLib
migueLib approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@migueLib migueLib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kbestak kbestak added this pull request to the merge queue Mar 20, 2024
Merged via the queue into nf-core:master with commit 7b29d1b Mar 20, 2024
10 checks passed
@kbestak kbestak deleted the clahe branch March 20, 2024 12:25
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_islandpath
2be1844 
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
294a9c0 
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
  Added gt/gff3validator (nf-core#4718)
  Added liftoff (nf-core#5209)
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@kbestak @FloWuenne @tucano
Added contrast limited adaptive histogram equalization module (nf-cor…
9f69906 
…e#5268)

* clahe_module

* removed todos

* Fixed linting, excluded conda tests.

* Added conda test skip to workflows/test.yml.

---------

Co-authored-by: Florian Wuennemann <[email protected]>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@kbestak @FloWuenne @jennylsmith
Added contrast limited adaptive histogram equalization module (nf-cor…
36dcdc0 
…e#5268)

* clahe_module

* removed todos

* Fixed linting, excluded conda tests.

* Added conda test skip to workflows/test.yml.

---------

Co-authored-by: Florian Wuennemann <[email protected]>
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@kbestak @FloWuenne
Added contrast limited adaptive histogram equalization module (nf-cor…
05e35d7 
…e#5268)

* clahe_module

* removed todos

* Fixed linting, excluded conda tests.

* Added conda test skip to workflows/test.yml.

---------

Co-authored-by: Florian Wuennemann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloWuenne FloWuenne FloWuenne left review comments

@migueLib migueLib migueLib approved these changes

@leoisl leoisl Awaiting requested review from leoisl leoisl was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbestak @FloWuenne @migueLib