-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new module - bamstats generalstats #4474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggabernet
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments, but otherwise looks good to me!
Hi @johnoooh @ggabernet, I created #3193 at the Hackaton in March last year. Now I see this PR (thanks @johnoooh). Do you guys think we can get this merged during this hackaton? Many thanks! Emilio |
emi80
force-pushed
the
bamstats
branch
5 times, most recently
from
March 19, 2024 14:44
ca236f2
to
1bbef79
Compare
Co-authored-by: Gisela Gabernet <[email protected]>
vlebars
pushed a commit
to vlebars/modules
that referenced
this pull request
Mar 20, 2024
* initial commit * commit to test * added :: * changed md5 * back to : * added comments and md5 * removed . * added bamstats to a line * spaces after colons * colon issues * sed tests * sed changes * sed fix * ' fix * sed fix * uising back * fix removed * sed fixed hopefully * md5 fix * removed todo * documentation added to meta.yml * removed todos * removed todo * fixed whitespace * fix licence * whitespace * whitespace again * para change * para change * md5 change * Update modules/nf-core/bamstats/generalstats/main.nf Co-authored-by: Gisela Gabernet <[email protected]> * todo removed * nf-test conversion * Fix bamstats module test.yml * Migrate bamstats tests to nf-test * Update bamstats/generalstats module and tests --------- Co-authored-by: Gisela Gabernet <[email protected]> Co-authored-by: Emilio Palumbo <[email protected]>
jvfe
added a commit
to jvfe/modules
that referenced
this pull request
Mar 20, 2024
* master: Added contrast limited adaptive histogram equalization module (nf-core#5268) Leviosam2 index (nf-core#5316) Add subworkflow mapAD (nf-core#5239) Remove AMRFinderPlus DB update on each invocation (nf-core#5232) Revert "add paths in output directive in cellranger cout module" (nf-core#5306) Revert "update kallistobustools count output list" (nf-core#5307) Igv reports (nf-core#5263) Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280) Add wittyer as module (nf-core#5171) Bamstats (nf-core#4474) gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164) 4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249) add cram/index support to bwamem2 (nf-core#5248) Add README to modules build with Docker (nf-core#4935) update paths for VEP (nf-core#5281) nf-test bases2fastq (nf-core#5272) Add module seqfu/stats (nf-core#5275)
jvfe
added a commit
to jvfe/modules
that referenced
this pull request
Mar 20, 2024
* master: Added contrast limited adaptive histogram equalization module (nf-core#5268) Leviosam2 index (nf-core#5316) Add subworkflow mapAD (nf-core#5239) Remove AMRFinderPlus DB update on each invocation (nf-core#5232) Revert "add paths in output directive in cellranger cout module" (nf-core#5306) Revert "update kallistobustools count output list" (nf-core#5307) Igv reports (nf-core#5263) Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280) Add wittyer as module (nf-core#5171) Bamstats (nf-core#4474) gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164) 4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249) add cram/index support to bwamem2 (nf-core#5248) Add README to modules build with Docker (nf-core#4935) update paths for VEP (nf-core#5281) nf-test bases2fastq (nf-core#5272) Add module seqfu/stats (nf-core#5275) Added gt/gff3validator (nf-core#4718) Added liftoff (nf-core#5209)
tucano
pushed a commit
to tucano/modules
that referenced
this pull request
Mar 20, 2024
* initial commit * commit to test * added :: * changed md5 * back to : * added comments and md5 * removed . * added bamstats to a line * spaces after colons * colon issues * sed tests * sed changes * sed fix * ' fix * sed fix * uising back * fix removed * sed fixed hopefully * md5 fix * removed todo * documentation added to meta.yml * removed todos * removed todo * fixed whitespace * fix licence * whitespace * whitespace again * para change * para change * md5 change * Update modules/nf-core/bamstats/generalstats/main.nf Co-authored-by: Gisela Gabernet <[email protected]> * todo removed * nf-test conversion * Fix bamstats module test.yml * Migrate bamstats tests to nf-test * Update bamstats/generalstats module and tests --------- Co-authored-by: Gisela Gabernet <[email protected]> Co-authored-by: Emilio Palumbo <[email protected]>
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
* initial commit * commit to test * added :: * changed md5 * back to : * added comments and md5 * removed . * added bamstats to a line * spaces after colons * colon issues * sed tests * sed changes * sed fix * ' fix * sed fix * uising back * fix removed * sed fixed hopefully * md5 fix * removed todo * documentation added to meta.yml * removed todos * removed todo * fixed whitespace * fix licence * whitespace * whitespace again * para change * para change * md5 change * Update modules/nf-core/bamstats/generalstats/main.nf Co-authored-by: Gisela Gabernet <[email protected]> * todo removed * nf-test conversion * Fix bamstats module test.yml * Migrate bamstats tests to nf-test * Update bamstats/generalstats module and tests --------- Co-authored-by: Gisela Gabernet <[email protected]> Co-authored-by: Emilio Palumbo <[email protected]>
alexnater
pushed a commit
to alexnater/nf-core-modules
that referenced
this pull request
Mar 21, 2024
* initial commit * commit to test * added :: * changed md5 * back to : * added comments and md5 * removed . * added bamstats to a line * spaces after colons * colon issues * sed tests * sed changes * sed fix * ' fix * sed fix * uising back * fix removed * sed fixed hopefully * md5 fix * removed todo * documentation added to meta.yml * removed todos * removed todo * fixed whitespace * fix licence * whitespace * whitespace again * para change * para change * md5 change * Update modules/nf-core/bamstats/generalstats/main.nf Co-authored-by: Gisela Gabernet <[email protected]> * todo removed * nf-test conversion * Fix bamstats module test.yml * Migrate bamstats tests to nf-test * Update bamstats/generalstats module and tests --------- Co-authored-by: Gisela Gabernet <[email protected]> Co-authored-by: Emilio Palumbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #3193
There are several tools named Bamstats, I have used this one before so I thought it fit to add.