Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subworkflow mapAD #5239

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add subworkflow mapAD #5239

merged 1 commit into from
Mar 20, 2024

Conversation

jch-13
Copy link
Contributor

@jch-13 jch-13 commented Mar 19, 2024 •
edited
Loading

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jch-13 jch-13 requested a review from TCLamnidis March 19, 2024 12:12
TCLamnidis
TCLamnidis requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@TCLamnidis TCLamnidis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests should be migrated to nf-tests instead of pytest.
Remove unused channels.

subworkflows/nf-core/fastq_align_mapad/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-core/fastq_align_mapad/main.nf Show resolved Hide resolved
subworkflows/nf-core/fastq_align_mapad/main.nf Show resolved Hide resolved
subworkflows/nf-core/fastq_align_mapad/main.nf Outdated Show resolved Hide resolved
@jch-13 jch-13 force-pushed the subwf_mm_mapAD branch 2 times, most recently from 33b93a9 to 99e90a1 Compare March 20, 2024 09:35
@jch-13 jch-13 requested a review from TCLamnidis March 20, 2024 09:45
TCLamnidis
TCLamnidis approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, otherwise LGTM!

subworkflows/nf-core/fastq_align_mapad/main.nf Outdated Show resolved Hide resolved
@jch-13 jch-13 added this pull request to the merge queue Mar 20, 2024
Merged via the queue into nf-core:master with commit 9f892b5 Mar 20, 2024
11 checks passed
@jch-13 jch-13 deleted the subwf_mm_mapAD branch March 20, 2024 12:09
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_islandpath
2be1844 
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
294a9c0 
* master:
  Added contrast limited adaptive histogram equalization module (nf-core#5268)
  Leviosam2 index (nf-core#5316)
  Add subworkflow mapAD (nf-core#5239)
  Remove AMRFinderPlus DB update on each invocation (nf-core#5232)
  Revert "add paths in output directive in cellranger cout module" (nf-core#5306)
  Revert "update kallistobustools count output list" (nf-core#5307)
  Igv reports (nf-core#5263)
  Remove unnecessary .view() in subworkflows/nf-core/vcf_phase_shapeit5 & tests/modules/nf-core/shapeit5/ligate/main.nf (nf-core#5280)
  Add wittyer as module (nf-core#5171)
  Bamstats (nf-core#4474)
  gatk4_asereadcounter add updated meta and nf-tests (nf-core#5164)
  4557 new module kaijumergeoutputs + stub Kraken2/Kraken2 (nf-core#5249)
  add cram/index support to bwamem2 (nf-core#5248)
  Add README to modules build with Docker (nf-core#4935)
  update paths for VEP (nf-core#5281)
  nf-test bases2fastq (nf-core#5272)
  Add module seqfu/stats (nf-core#5275)
  Added gt/gff3validator (nf-core#4718)
  Added liftoff (nf-core#5209)
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@jch-13 @tucano
Add subworkflow mapAD (nf-core#5239)
97785e5 
Add mapAD subworkflow
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@jch-13 @jennylsmith
Add subworkflow mapAD (nf-core#5239)
0e28b2c 
Add mapAD subworkflow
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@jch-13
Add subworkflow mapAD (nf-core#5239)
5703812 
Add mapAD subworkflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCLamnidis TCLamnidis TCLamnidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jch-13 @matthdsm @TCLamnidis