Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.2 patch release #703

Merged
merged 167 commits into from
Mar 16, 2021
Merged

2.3.2 patch release #703

merged 167 commits into from
Mar 16, 2021

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Mar 15, 2021

Pipeline patch release for 2.3.2!

Lots of bugs and some refactoring and a couple of very minor additions:

Biggest changes are:

  • Replacement of bash conditions with nextflow
  • Added new process to rename input sexdetermine
  • Added a few validation checks

New contributors: @alexandregilardet & @IdoBar

[Note: hold off final merge until we get PeerJ citation info to update on README 👍 ]

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

jfy133 and others added 30 commits January 14, 2021 14:24
Merge pull request #660 from jfy133/dev
Post-release version bump
Following issue #652, I would like to propose to explicitly mention that `skip_collapse` turns on paired-end alignment, so that a keyword search in the _parameters_ page of the documentation will reveal the information.
Replace `val` with `path` to correct staging of input files
Replace `val` with `path` to correct staging of input files
Correct line spacing in markdown
Fix file staging for print_nuclear_contamination
Document that `skip_collapse` turns on paired-end alignment.
@jfy133 jfy133 requested a review from a team March 15, 2021 19:42
@jfy133 jfy133 changed the title Dev 2.3.2 patch release Mar 15, 2021
docs/usage.md Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
nextflow_schema.json Show resolved Hide resolved
@jfy133 jfy133 requested a review from mashehu March 16, 2021 11:25
@jfy133
Copy link
Member Author

jfy133 commented Mar 16, 2021

ignoring that one flaky bam_filtering CI test...

@jfy133 jfy133 merged commit b5a8f0f into master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants