Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min nf bump #663

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Min nf bump #663

merged 4 commits into from
Jan 14, 2021

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 14, 2021

Identified when looking at AWS test results: AWS pulls 20.04.1 which had a bug with nested-Nf parameters. Although 20.04.0 worked, .1 doesn't so we need to jump to the next stable release (20.07.1).

to close #631

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 changed the base branch from master to dev January 14, 2021 13:49
@github-actions
Copy link

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@apeltzer apeltzer merged commit 97d1353 into nf-core:dev Jan 14, 2021
@jfy133 jfy133 deleted the min-nf-bump branch March 15, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown config attribute with test_tsv profile with Nextflow 20.04
2 participants