Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release with readgroup fixes and to get docker working #660

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 14, 2021

On the tin. Read group bugs/fixes from @IdoBar and additional schema fix for value types.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@jfy133 jfy133 changed the base branch from master to dev January 14, 2021 10:43
@jfy133 jfy133 merged commit 0644abd into nf-core:dev Jan 14, 2021
jfy133 added a commit to jfy133/nf-core-eager that referenced this pull request Jan 14, 2021
Merge pull request nf-core#660 from jfy133/dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants