Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-release version bump #59

Merged
merged 8 commits into from
Jul 5, 2023
Merged

Post-release version bump #59

merged 8 commits into from
Jul 5, 2023

Conversation

SusiJo
Copy link
Collaborator

@SusiJo SusiJo commented May 31, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bamtofastq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 20a8e16

+| ✅ 159 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-31 15:16:42

d4straub
d4straub approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SusiJo SusiJo merged commit 7571ca5 into nf-core:dev Jul 5, 2023
FriederikeHanssen
FriederikeHanssen reviewed Jul 5, 2023
View reviewed changes
nextflow.config
@@ -232,8 +232,8 @@ manifest {
description = """Workflow converts one or multiple bam/cram files to fastq format"""
mainScript = 'main.nf'
nextflowVersion = '!>=22.10.1'
version = '2.0.0'
doi = ''
version = '2.1.0dev'
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen Jul 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this alignment is abyssmal :D But can be fixed later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik this is due to the bump-version, this is always not aligned, I gave up there as well :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SusiJo @mirpedrol @FriederikeHanssen @d4straub @BrunoGrandePhD