-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpxv temporal colouring scale #57
Conversation
Note: this requires forthcoming PRs in augur and auspice
Augur PR: nextstrain/augur#969 (Update: done, released & image updated) |
Both of the prereq PRs above have been merged. Auspice is released (2.37.3) and the augur change should be released tomorrow 🤞 Update: The augur release will be 16.0, and this will require a few more things too:
|
This has been done: |
This is necessary for the temporal colour scale introduced in the preceding commit. For searchibility i'll past the error message that you would get when running with <16.0.0 (which shouldn't be reachable as the snakemake pipeline should exit up front): ERROR: 'temporal' is not one of ['continuous', 'ordinal', 'categorical', 'boolean'] Validation of config/auspice_config_mpxv.json failed.
Added a commit to ensure we're running augur v16, which is causing CI to fail as |
I've restarted failing CI to see if the new image has propagated by now @jameshadfield |
After merging recent changes this now passes tests and should be mergable - but I leave the button pushing to you @jameshadfield :) |
Thanks for merging this -- it's the nice thing about working across different time zones 😂
I've not heard them called 🍰 but I like it. Continuous scales (and temporal is a continuous scale with small tweaks) get colour blending (e.g. https://next.nextstrain.org/zika/?c=num_date&d=map&p=full), however it's been a to-do to explore discretising these (e.g. via the binning in the legend) to produce a 🍰 . It would certainly make the map code simpler! |
Note: this requires forthcoming PRs in augur and auspice, and I'll notify here when released etc. Because of this i'll keep this as a draft PR.
The end result is