Allow temporal scales #1523
Merged
Allow temporal scales #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a feature I've long wanted & it does it the quick and easy way: by requiring that the value already be numeric! In the future it'd be nice to allow YYYY-MM-DD values, but that's for another PR (and comes with its own complexities - what about -XX dates?) This commit will require a corresponding one in augur to update the schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a feature I've long wanted & it does it the quick and
easy way: by requiring that the value already be numeric! In the future
it'd be nice to allow
YYYY-MM-DDvalues, but that's for another PR (andcomes with its own complexities regarding ambiguity).
This PR is related to nextstrain/augur#969 and an example output is available at nextstrain/mpox#57
This was part of #1519 (ill remove this commit from that PR when I revisit it)