Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make submission_date scale temporal, parallel to mpxv change #73

Closed

Conversation

corneliusroemer
Copy link
Member

Description of proposed changes

I mirrored the changes @jameshadfield made to mpxv build to hmpxv1 in #57

I'm not quite sure what the effect is, nothing seems to have changed to my eyes. So maybe this is not supposed to be changed? It doesn't do any harm though, either.

@jameshadfield can you enlighten me what the temporal scale does differently than not specifying it?

Testing

Ran it locally, looked good

@rneher
Copy link
Member

rneher commented Jun 20, 2022

in hxmpv we do time tree inference. hence we color can by numdate instead. This is probably a magic field.

@corneliusroemer
Copy link
Member Author

I see, in that case I'll close this PR, makes sense!

@corneliusroemer corneliusroemer deleted the chore/switch-hmpxv1-submit-date-to-temporal branch June 20, 2022 20:15
@jameshadfield
Copy link
Member

Yeah -- numdate (or num_date) were the only colorings which could be temporal in auspice, and they had to be defined across all nodes in the tree (e.g. via timetree). My changes open this up to arbitrary colourings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants