MS-Windows: fix markdown.mjs path issue

[ikappaki]

Hi,

could you please consider fix for markdown and git:/ issues described in #29.

The markdown fix is to include the URL path verbatim in the js import (otherwise the path is invalid, because it starts with a leading slash, e.g. /C:/...).

The fix for the clerk dependency issue is to switch from git:/ to https:/ . The git protocol can be more demanding than https. The initial error I had encountered was with clojure cli tool trying to checkout clerk using the git protocol by calling the git command line tool. The latter calls ssh to instrument the download. On MS-Windows putty link is used as a replacement for ssh, and it might block waiting for user to confirm the server's fingerprint when first encountering a remote git server it does not know about. If bootstrapping from a IDE such as Cider, the message might not come through to the user, "freezing" the whole process without feedback. Suggestion thus is to switch to https:/, which is less demanding and should work in most cases without an issue.

Thanks.

[zampino]

Hi @ikappaki thanks a lot for reporting these problems! Both issues (I think) were addressed in #31 where we had to change how Graal polyglot context loads the javascript module.

[ikappaki]

Hi @zampino. Thanks for looking into this . The issue with the deps have been fixed, but the polyglot issue still persists.

This time the exception is coming from inside polyglot, probably they are applying the same treatment as the markdown module did earlier.

https://github.com/oracle/graal/blob/cf1887f14079502f59a787b13b194e123986f62a/sdk/src/org.graalvm.polyglot/src/org/graalvm/polyglot/Source.java#L547
https://github.com/oracle/graal/blob/cf1887f14079502f59a787b13b194e123986f62a/sdk/src/org.graalvm.polyglot/src/org/graalvm/polyglot/impl/AbstractPolyglotImpl.java#L335
(...need to dig deeper..)

Would you consider a workaround to wrap that the resource in a file instead ?
ikappaki@5338a7c

Tested to work under both MS-Windows and Linux, but not sure how to test with your jar example mention in #31.

Thanks,

clojure -X:test/markdown

Execution error (PolyglotException) at sun.nio.fs.WindowsPathParser/normalize (WindowsPathParser.java:182).
java.nio.file.InvalidPathException: Illegal char <:> at index 2: /D:/src/viewers/modules/markdown/resources/js/markdown.mjs