Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Emacs lock files from visualising #23

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Dec 4, 2021

Hi,

could you please consider patch to ignore files whose names begins with .# because are most likely Emacs lock files that Clerk might try to visualize on MS-Windows as described in #22?

I've introduce the first unit test to test the same (happy to remove if you think is too much or you have other plans for unit testing).

Lastly, I've changed git:/ to https:/ in deps, since these are likely to cause unexpected blocking issues on MS-Windows (see nextjournal/viewers#30 for a description).

I've also added Emacs temp files ending with ~ in.gitignore.

Also upgraded shadow-cljs version to 2.16.7 to solve issue with gitlibs when they are stored on a separate drive than the project (see thheller/shadow-cljs#966 for the details).

Please feel free to scrutinize.

Thanks.

Closes #22.

Also upgraded shadow-cljs to 2.16.7 to solve potential issue with
gitlibs on MS-Windows.
@ikappaki ikappaki force-pushed the issue/emacs-lock-files branch from 7e62605 to 0078fe6 Compare December 5, 2021 10:47
@jackrusher
Copy link
Collaborator

@ikappaki Thanks for all this Windows QA and patches! None of the primary developers uses Windows, so this is very helpful. :) We'll take a look at your patches early this coming week.

@mk mk force-pushed the issue/emacs-lock-files branch from 58dfe9e to 1a086e1 Compare December 8, 2021 12:21
@mk
Copy link
Member

mk commented Dec 8, 2021

Hi @ikappaki,

Thanks a lot for your PR! I've made some small changes: we do indeed have other plans for tests, so I've moved them to comments for now. Also io.github.nextjournal/cas is currently still private so I've reverted your change here.

Please give main a spin and let me know if everything works for you on windows now, thanks a lot!

@mk mk merged commit 6126a2e into nextjournal:main Dec 8, 2021
@ikappaki
Copy link
Contributor Author

ikappaki commented Dec 8, 2021

Please give main a spin and let me know if everything works for you on windows now, thanks a lot!

Hi @mk, thanks for the merge! Tested to be working fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clerk can fail to visualize file when editing with Emacs on MS-Windows
3 participants