Prepare Release of Markdown Module #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zampino
commented
Dec 6, 2021
zampino
commented
- silence GraalJS warning for interpreted mode
- drop nextjournal.log dependency (not on clojars)
- Fixes Failure to load markdown viewer on MS-Windows #29
- add tools build alias
This comment has been minimized.
This comment has been minimized.
by uniforming dep names for nextjournal/log lib
by dropping the evaluation of an 'import' statement in favour of using context option 'js.esm-eval-returns-exports' which allows returning exports as a Polyglot value when we evaluate an esm source file. Also remove separate polyglot engine as it doesn't fix the "interpreter only" warning when graal libraries are loaded by a stock JVM.
zampino
force-pushed
the
release-markdown
branch
from
1cd8411 to
ce0da9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.