-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): combine navigation and files list into single Vue app #43090
Merged
JuliaKirschenheuter
merged 2 commits into
master
from
fix/files--combine-navigation-and-app
Jan 25, 2024
Merged
fix(files): combine navigation and files list into single Vue app #43090
JuliaKirschenheuter
merged 2 commits into
master
from
fix/files--combine-navigation-and-app
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
changed the title
fix(files): combine navigation and files list in one Vue app
fix(files): combine navigation and files list into single Vue app
Jan 24, 2024
ShGKme
requested review from
nickvergessen,
susnux,
JuliaKirschenheuter,
artonge and
skjnldsv
January 24, 2024 21:42
ShGKme
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jan 24, 2024
ShGKme
force-pushed
the
fix/files--combine-navigation-and-app
branch
2 times, most recently
from
January 24, 2024 22:38
2806fb0
to
3840a99
Compare
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/files--combine-navigation-and-app
branch
from
January 24, 2024 23:26
3840a99
to
aa18769
Compare
skjnldsv
approved these changes
Jan 25, 2024
artonge
approved these changes
Jan 25, 2024
JuliaKirschenheuter
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great, thank you!
/backport b40279e to stable28 |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main
landmark on files page #43085Summary
During
files2vue
migration, files were migrated as two Vue apps:<NcAppNavitation>
<NcAppContent>
But Vue app in Nextcloud is supposed to be one NcContent app that contains navigation and content.
After migration has finished there is no need to separate Navigation and FilesList.
TODO
Screenshots
No visual changes on both user files and public share
Checklist