-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): right click actions menu #43254
Conversation
Signed-off-by: John Molakvoæ <[email protected]>
/backport! to backport/43090/stable28 |
@@ -346,7 +346,7 @@ export default Vue.extend({ | |||
<style lang="scss"> | |||
// Allow right click to define the position of the menu | |||
// only if defined | |||
.app-content[style*="mouse-pos-x"] .v-popper__popper { | |||
.content[style*="mouse-pos-x"] .v-popper__popper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it the same? Do we need root class here at all?
.content[style*="mouse-pos-x"] .v-popper__popper { | |
[style*="mouse-pos-x"] .v-popper__popper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it far less efficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it far less efficient?
Probably it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good - however, it seems that firefox has had yet another regression (😓😓):
I remember this being mentioned in a PR before, but I cannot remember for the life of me which PR it was! If you believe this can be ignored for now / chrome is where most people use NC, I can go ahead and submit an approval
After #43090
The root changed
server/apps/files/src/components/FileEntry.vue
Lines 402 to 407 in 1b0eb2b