Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave only onemain landmark on files page #43085

Closed
JuliaKirschenheuter opened this issue Jan 24, 2024 · 4 comments · Fixed by #43090 or #43108
Closed

Leave only onemain landmark on files page #43085

JuliaKirschenheuter opened this issue Jan 24, 2024 · 4 comments · Fixed by #43090 or #43108
Assignees
Labels
1. to develop Accepted and waiting to be taken care of accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jan 24, 2024

There should be only one main landmark on the page. If there are any reasons to have several then we have to differentiate between them: https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/main.html

In my eyes there is no reason to have several main landmarks for files page. On all other pages (which are migrated to vue) there is only app-content-vue main landmark, like:

Screenshot from 2024-01-24 16-39-03

Actually <main id="content" class="app-files"> should not exist because files page is already migrated to vue.

@ShGKme

This comment was marked as outdated.

@JuliaKirschenheuter

This comment was marked as outdated.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 26, 2024

Waiting for the backport

@ShGKme ShGKme reopened this Jan 26, 2024
@szaimen szaimen removed the bug label Jan 26, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

closing as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
3 participants