Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Psalm version for security analysis #28700

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Pin Psalm version for security analysis #28700

merged 1 commit into from
Sep 3, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 3, 2021 •
edited
Loading

The action will otherwise pull dev-master and this can break easily as
we just experienced.

Ref https://github.com/psalm/psalm-github-actions#specify-psalm-version
Ref #28692 (comment)

@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Sep 3, 2021
@ChristophWurst ChristophWurst self-assigned this Sep 3, 2021
@ChristophWurst

This comment has been minimized.

Sign in to view
@ChristophWurst ChristophWurst force-pushed the fix/psalm-security-analysis-pin-version branch from d9acf72 to 34c53d5 Compare September 3, 2021 10:02
@MichaIng
Copy link
Member

MichaIng commented Sep 3, 2021

Does this also cover

Uncaught Error: Interface 'Psr\EventDispatcher\StoppableEventInterface' not found in /github/workspace/lib/public/EventDispatcher/Event.php:43

found in #28426 and #28264?

@ChristophWurst
Copy link
Member Author

Does this also cover

Uncaught Error: Interface 'Psr\EventDispatcher\StoppableEventInterface' not found in /github/workspace/lib/public/EventDispatcher/Event.php:43

found in #28426 and #28264?

Yes, it's fixing this issue precisely :)

@ChristophWurst
Pin Psalm version for security analysis
7559a4a 
The action will otherwise pull dev-master and this can break easily as
we just experience.

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the fix/psalm-security-analysis-pin-version branch from 34c53d5 to 7559a4a Compare September 3, 2021 11:52
@ChristophWurst ChristophWurst merged commit cd8b17f into master Sep 3, 2021
@ChristophWurst ChristophWurst deleted the fix/psalm-security-analysis-pin-version branch September 3, 2021 12:44
This was referenced Sep 3, 2021
Merged
Merged
Merged
@MichaIng
Copy link
Member

MichaIng commented Sep 3, 2021

This requires backport as same errors appear on stable21 and stable22, right?

@MichaIng
Copy link
Member

MichaIng commented Sep 3, 2021

/backport to stable22

@MichaIng
Copy link
Member

MichaIng commented Sep 3, 2021

/backport to stable21

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 3, 2021
Merged
@MichaIng MichaIng mentioned this pull request Sep 3, 2021
Merged
@MichaIng
Copy link
Member

MichaIng commented Sep 3, 2021

Manual backport to stable21 required as dedicated psalm-github.yml workflow does not yet exist there: #28706

@Esmking
Copy link

Esmking commented Sep 3, 2021

313

@ChristophWurst ChristophWurst mentioned this pull request Sep 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug security
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @MichaIng @Esmking @skjnldsv @CarlSchwan