-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vimeo/psalm from 4.8.1 to 4.9.2 #28338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.8.1 to 4.9.2. - [Release notes](https://github.com/vimeo/psalm/releases) - [Commits](vimeo/psalm@4.8.1...4.9.2) --- updated-dependencies: - dependency-name: vimeo/psalm dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
39ba876
to
a4f3371
Compare
for the event listener registration. This smells like a bug but I can't reproduce this in the Psalm repl: https://psalm.dev/r/e64f3a9d3d |
I think the issue is that the template is not taken into account on the implementing class. Non-working example: https://psalm.dev/r/ecd0c19708 Working example with additional annotation: https://psalm.dev/r/ddcc007769 Not sure if there may be a different way to annotate this without hinting every event listener properly. |
Wait … so Psalm actually got more clever. It now finally verifies that the listener you register is one for the specified type. This was a limitation in the past: vimeo/psalm#4339 |
Maybe what we need is a typehint for the listener to say it's either a listener for T or one without a type at all. let me try that |
I'm getting closer yet it doesn't work https://psalm.dev/r/511e39f9b2 |
I think that the naming for T might conflict there, using a different identifier seems to work: https://psalm.dev/r/39bacb4d3b Edit: Ah it seems the |
Then we still can't use a typed event for an untyped listener: https://psalm.dev/r/065f604762 :/ |
Never mind that basically allows any event to be passed to the typed listener then |
If we can't figure it out I would suggest to drop the generics from the listener registration. I've found listeners in Mail where we listen to more than one specialized event and there seems no way to express this with generics. |
This comment has been minimized.
This comment has been minimized.
@dependabot recreate |
I'll close this, as it is completely obsolete and also dependabot does not react on it anymore. |
Bumps vimeo/psalm from 4.8.1 to 4.9.2.
Release notes
Sourced from vimeo/psalm's releases.
... (truncated)
Commits
00c0622
Fix spacea205a23
Fix #6212 - remove untested code, add test for reasonable behaviouredffb1a
Merge pull request #6213 from weirdan/scan-preloaded-stubs-earlier2562e37
Scan preloaded stubs earlier7e137f5
Improve internals of TIntRange (#6208)c62adf9
Merge pull request #6198 from mmcev106/master3a049df
Merge pull request #6207 from orklah/int-rangeba9f7d0
fix CS0252a65
fix syntax1e3e6a8
introduce basic integer rangeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)