Bump p-limit from 3.1.0 to 4.0.0

[dependabot]

Bumps p-limit from 3.1.0 to 4.0.0.

Release notes

Sourced from p-limit's releases.

v4.0.0

Breaking

• Require Node.js 12.20 9e08401
• This package is now pure ESM. Please read this.

sindresorhus/p-limit@v3.1.0...v4.0.0

Commits

• 38a6773 4.0.0
• 9e08401 Require Node.js 12.20 and move to ESM
• cada94e Minor refactor (#50)
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[artonge]

Here is the error:

    ERROR in ./node_modules/yocto-queue/index.js 7:6
    Module parse failed: Unexpected token (7:6)
    You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
    | 
    | class Node {
    > 	value;
    | 	next;
    | 
     @ ./node_modules/p-limit/index.js 17:0-32 23:18-23
     @ ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib??vue-loader-options!./apps/settings/src/components/AppList.vue?vue&type=script&lang=js&
     @ ./apps/settings/src/components/AppList.vue?vue&type=script&lang=js&
     @ ./apps/settings/src/components/AppList.vue
     @ ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib??vue-loader-options!./apps/settings/src/views/Apps.vue?vue&type=script&lang=js&
     @ ./apps/settings/src/views/Apps.vue?vue&type=script&lang=js&
     @ ./apps/settings/src/views/Apps.vue
     @ ./apps/settings/src/router.js
     @ ./apps/settings/src/main-apps-users-management.js

This might be babel not handling this syntax. But not sure.

[MichaIng]

Same error at a second script:

    ERROR in ./node_modules/yocto-queue/index.js 7:6
    Module parse failed: Unexpected token (7:6)
    You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
    | 
    | class Node {
    > 	value;
    | 	next;
    | 
     @ ./node_modules/p-limit/index.js 17:0-32 23:18-23
     @ ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib??vue-loader-options!./core/src/components/setup/RecommendedApps.vue?vue&type=script&lang=js&
     @ ./core/src/components/setup/RecommendedApps.vue?vue&type=script&lang=js&
     @ ./core/src/components/setup/RecommendedApps.vue
     @ ./core/src/recommendedapps.js

Probably the actual change was not the p-limit bump but the implicit yocto-queue bump from 0.1.0 to 1.0.0, e.g.: sindresorhus/yocto-queue@v0.1.0...v1.0.0#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346

Those changes do not tell me anything, but the first uncommented code line is what both error messages point at 🧐.

[MichaIng]

@dependabot rebase

[artonge]

Might have fixed it by adding yocto-queue to the BabelLoaderExcludeNodeModulesExceptlist 🎉

[MichaIng]

Okay, I don't understand the impact of this, but CI is happy now.

[artonge]

Okay, I don't understand the impact of this, but CI is happy now.

It simply tells webpack to not run this module through babel.

[MichaIng]

And why was this not required before? Sorry for asking, just curious to understand and learn how thinks work 😄.

[artonge]

And why was this not required before? Sorry for asking, just curious to understand and learn how thinks work smile.

They switch to being an Ecmascript module[0][1]. I have no idea why babel is not able to load it correctly, but p-limit was already in that list, so I simply try to and it worked.

[0] sindresorhus/yocto-queue@0228034#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R13
[1] https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

[MichaIng]

Probably related: https://stackoverflow.com/a/60341180/16145737

The commend above this exception list points to the same direction:

// automatically detect necessary packages to
// transpile in the node_modules folder

But to me it looks more like a ToDo, so that this auto-detection and transpiling should be done instead of manually adding pure ESM to that exception list. However, should be fine for now, until someone finds time to implement the actual solution.