-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper PHPDoc tags to files ApiController #26410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Apr 8, 2021
Psalm is not happy |
server/lib/private/User/Session.php Lines 227 to 229 in f99f463
|
Merged
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
MorrisJobke
force-pushed
the
fix/noid/phpdoc
branch
from
May 21, 2021 14:58
e0f373a
to
bcf01a1
Compare
Rebased - maybe Psalm is happy. |
MorrisJobke
requested review from
juliusknorr,
LukasReschke,
PVince81 and
ChristophWurst
May 27, 2021 18:03
CI failure is unrelated |
PVince81
approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This broke tests on master :( |
LukasReschke
added a commit
that referenced
this pull request
May 28, 2021
Regression by #26410 Signed-off-by: Lukas Reschke <[email protected]>
Merged
LukasReschke
added a commit
that referenced
this pull request
May 28, 2021
Regression by #26410 Signed-off-by: Lukas Reschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make Psalm a bit more happy (because it does not need to infer it)