Merge pull request #26410 from nextcloud/fix/noid/phpdoc

Add proper PHPDoc tags to files ApiController
nextcloud · May 27, 2021 · e312905 · e312905
2 parents 2607b57 + bcf01a1
commit e312905
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/apps/files/lib/Controller/ApiController.php b/apps/files/lib/Controller/ApiController.php
@@ -67,9 +67,9 @@ class ApiController extends Controller {
 	private $shareManager;
 	/** @var IPreview */
 	private $previewManager;
-	/** IUserSession */
+	/** @var IUserSession */
 	private $userSession;
-	/** IConfig */
+	/** @var IConfig */
 	private $config;
 	/** @var Folder */
 	private $userFolder;
@@ -291,8 +291,8 @@ public function updateFileSorting($mode, $direction) {
 	 * @return Response
 	 * @throws \OCP\PreConditionNotMetException
 	 */
-	public function showHiddenFiles($show) {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', (int)$show);
+	public function showHiddenFiles(bool $show): Response {
+		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', $show ? '1' : '0');
 		return new Response();
 	}
 
@@ -305,8 +305,8 @@ public function showHiddenFiles($show) {
 	 * @return Response
 	 * @throws \OCP\PreConditionNotMetException
 	 */
-	public function cropImagePreviews($crop) {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', (int)$crop);
+	public function cropImagePreviews(bool $crop): Response {
+		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', $crop ? '1' : '0');
 		return new Response();
 	}
 
@@ -319,8 +319,8 @@ public function cropImagePreviews($crop) {
 	 * @return Response
 	 * @throws \OCP\PreConditionNotMetException
 	 */
-	public function showGridView($show) {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', (int)$show);
+	public function showGridView(bool $show): Response {
+		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', $show ? '1' : '0');
 		return new Response();
 	}
 
@@ -345,13 +345,13 @@ public function getGridView() {
 	 * @return Response
 	 * @throws \OCP\PreConditionNotMetException
 	 */
-	public function toggleShowFolder(int $show, string $key) {
+	public function toggleShowFolder(int $show, string $key): Response {
 		// ensure the edited key exists
 		$navItems = \OCA\Files\App::getNavigationManager()->getAll();
 		foreach ($navItems as $item) {
 			// check if data is valid
 			if (($show === 0 || $show === 1) && isset($item['expandedState']) && $key === $item['expandedState']) {
-				$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', $key, $show);
+				$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', $key, (string)$show);
 				return new Response();
 			}
 		}