Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper PHPDoc tags to files ApiController #26410

Merged
merged 2 commits into from
May 27, 2021
Merged

Add proper PHPDoc tags to files ApiController #26410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb1d16d
Add proper PHPDoc tags to files ApiController
MorrisJobke Apr 1, 2021
bcf01a1
Fix more psalm warnings
rullzer Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions apps/files/lib/Controller/ApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ class ApiController extends Controller {
private $shareManager;
/** @var IPreview */
private $previewManager;
/** IUserSession */
/** @var IUserSession */
private $userSession;
/** IConfig */
/** @var IConfig */
private $config;
/** @var Folder */
private $userFolder;
Expand Down Expand Up @@ -291,8 +291,8 @@ public function updateFileSorting($mode, $direction) {
* @return Response
* @throws \OCP\PreConditionNotMetException
*/
public function showHiddenFiles($show) {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', (int)$show);
public function showHiddenFiles(bool $show): Response {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', $show ? '1' : '0');
return new Response();
}

Expand All @@ -305,8 +305,8 @@ public function showHiddenFiles($show) {
* @return Response
* @throws \OCP\PreConditionNotMetException
*/
public function cropImagePreviews($crop) {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', (int)$crop);
public function cropImagePreviews(bool $crop): Response {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', $crop ? '1' : '0');
return new Response();
}

Expand All @@ -319,8 +319,8 @@ public function cropImagePreviews($crop) {
* @return Response
* @throws \OCP\PreConditionNotMetException
*/
public function showGridView($show) {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', (int)$show);
public function showGridView(bool $show): Response {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', $show ? '1' : '0');
return new Response();
}

Expand All @@ -345,13 +345,13 @@ public function getGridView() {
* @return Response
* @throws \OCP\PreConditionNotMetException
*/
public function toggleShowFolder(int $show, string $key) {
public function toggleShowFolder(int $show, string $key): Response {
// ensure the edited key exists
$navItems = \OCA\Files\App::getNavigationManager()->getAll();
foreach ($navItems as $item) {
// check if data is valid
if (($show === 0 || $show === 1) && isset($item['expandedState']) && $key === $item['expandedState']) {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', $key, $show);
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', $key, (string)$show);
return new Response();
}
}
Expand Down