Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentioned user not clickable after posting a comment #4555

Closed
nickvergessen opened this issue Apr 27, 2017 · 3 comments
Closed

Mentioned user not clickable after posting a comment #4555

nickvergessen opened this issue Apr 27, 2017 · 3 comments
Assignees
@georgehrke
Labels
3. to review Waiting for reviews bug feature: comments
Milestone
Nextcloud 12.0

Comments

@nickvergessen
Copy link
Member

Page needs to be reloaded before this is possible.
@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Apr 27, 2017
@georgehrke georgehrke mentioned this issue Apr 27, 2017
Closed
11 tasks
@jancborchardt
Copy link
Member

For me it wasn’t even possible for existing comments somehow … :/

@georgehrke
Copy link
Member

For me it wasn’t even possible for existing comments somehow … :/

Can you check if there is any js error and if the contacts menu popover is properly added to the DOM?

danxuliu added a commit that referenced this issue May 8, 2017
@danxuliu
Fix mentioned user not clickable after posting or editing a comment
0db3a41 
The contactsMenu plugin was called on avatar elements from
_postRenderItem, which is called when a new comment is added to the
collection. Due to this contactsMenu was not called when messages were
edited; when a new comment is posted _postRenderItem is called, but at
that time the "mentions" attribute is not filled yet, so "@username" is
not replaced by avatars in the message and thus contactsMenu has no
avatars to be called on.

Calling contactsMenu was moved to a new method, _postRenderMessage,
which is called from _postRenderItem and from the success callback when
fetching the model in _onSubmitSuccess (which replaces "@username" by
avatars in the message after posting or editing a comment).

Fixes #4555

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu danxuliu mentioned this issue May 8, 2017
Merged
@MorrisJobke
Copy link
Member

Fix is in #4746

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 8, 2017
@georgehrke georgehrke mentioned this issue May 16, 2017
Merged
This was referenced Jun 21, 2018
Open
Open
@nextcloud-bot nextcloud-bot mentioned this issue Nov 20, 2018
Closed
This was referenced Sep 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgehrke georgehrke

Labels
3. to review Waiting for reviews bug feature: comments
Projects
None yet
Milestone
Nextcloud 12.0
Development

No branches or pull requests
4 participants
@nickvergessen @MorrisJobke @jancborchardt @georgehrke