Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that you can now click on usernames #4554

Merged
merged 1 commit into from
May 16, 2017
Merged

Make it clear that you can now click on usernames #4554

merged 1 commit into from
May 16, 2017

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 27, 2017 •
edited
Loading

@georgehrke any idea?^

@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Apr 27, 2017
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @MorrisJobke and @skjnldsv to be potential reviewers.

@georgehrke
Copy link
Member

georgehrke commented Apr 27, 2017 •
edited by nickvergessen
Loading

After posting a comment the page needs to be reloaded before mentions are clickable

probably a bug. Do you mind creating an issue and assigning it to me? => #4555

@jancborchardt jancborchardt self-requested a review April 27, 2017 18:31
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 16, 2017
@nickvergessen nickvergessen removed the request for review from jancborchardt May 16, 2017 14:20
@nickvergessen
Copy link
Member Author

Please review this nitpick @rullzer @LukasReschke

@LukasReschke LukasReschke merged commit 15f7fe0 into master May 16, 2017
@LukasReschke LukasReschke deleted the pointer-cursor-on-clickable-user branch May 16, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: comments
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @mention-bot @georgehrke @LukasReschke