Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivated users should not be suggested in chat/comments mentions and on the sharee endpoint. #9948

Open
nickvergessen opened this issue Jun 21, 2018 · 10 comments

Comments

@nickvergessen
Copy link
Member

See nextcloud/spreed#959

Or does anyone know a reason why they should? @MorrisJobke @blizzz

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #6755 (Disabled users should not be suggested in the sharee dialog), #4555 (Mentioned user not clickable after posting a comment), #753 (user mentions in comments), #6038 (User shouldn't be shown in contactlist if the account is deactivated), and #2443 (Missing pieces: user mentions in Comments).

@MorrisJobke
Copy link
Member

Those two are the counter parts for contact list and share dialog:

#6755 (Disabled users should not be suggested in the sharee dialog)

#6038 (User shouldn't be shown in contactlist if the account is deactivated)

@diplodata
Copy link

Also it should not be possible to initiate a Talk conversation with a disabled user. At present you can, by clicking on the Talk to x button in the Search contacts dropdown list - a new chat thread appears in Talk and there is no notification that the other user is disabled.

@nickvergessen
Copy link
Member Author

@diplodata that is the same issue. It's all using the same endpoint ;)

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of feature: sharing labels Jun 7, 2019
@szaimen

This comment was marked as outdated.

@blizzz
Copy link
Member

blizzz commented May 21, 2021

Disabling users was designed to only reject them logging in. If we want this to change, we ought to write a comprehensive concept describing what the consequences shall be generally, not just about a single point.

@szaimen

This comment was marked as outdated.

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@nickvergessen
Copy link
Member Author

Still an issue

@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of and removed needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 9, 2023
@nickvergessen
Copy link
Member Author

But maybe bug is the wrong label. It's more of a discussion field of what the scope is and to clarify it. Currently it fails to match 90% of the user expectations.

@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

then lets use a different label :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants