-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
share dialog doesn't show more then two exact matches? #10114
Comments
@schiessle at least for the guests app it isn't a JavaScript limit. The guests app handles the autocomplete different (https://github.com/nextcloud/guests/blob/make-compatible-with-nextcloud/js/app.js#L171). It doesn't recognize the email shares yet. I'll have a look at this and will update the guests app "make-compatible-with-nextcloud" branch. |
Signed-off-by: Michael Weimann <[email protected]>
What is the status of this issue? Still make sense? |
We show a bit more now I think :) |
I just noticed that on master only two exact matches are shown in the share dialog.
If I test the guest app (nextcloud/guests#1) or federated group shares (#9895) always only two exact matches are shown. In case of the guest apps this means the guest email address and the same address with the option to send a federated share (remote) and in case of federated group sharing it shows the option to send a federated share (remote) or a federated group share (remote group) but the "share by mail option" is always missing although the API returns all three results correctly.
Therefore I assume that we limit the list of exact matches to two. Can some of our JS experts check this and remove this limit? Thanks!
@nextcloud/javascript
The text was updated successfully, but these errors were encountered: