[WIP] Nextcloud compatibility

[LukasReschke]

No description provided.

[LukasReschke]

@jancborchardt Can you please create an icon? THX.

[jancborchardt]

Done, see #13 :)

[rullzer]

I just rebased. It now tries to run the intergration tests. So they should be green once this PR is merged.

[icewind1991]

Basic stuff should be working now

todo:

• sending email notifications for new shares to existing guests (uses some new oc mail notification system from what I can tell)
• email notifications have broken logo image
• since invite re-uses password reset, the invite link will expire after 12 hours
• app whitelist should hide nav entries for non enabled apps
• app whitelist config ui is horrible

[icewind1991]

The app currently only suggest guest account when you enter a name and not an email.

I'll extend it to also work properly when you type a mail

[schiessle]

The app currently only suggest guest account when you enter a name and not an email.

Ah, ok... This way it works.

If I go the user management and select the guest group the guest user is added endless times. Also if I scroll down it never ends. 😄

Also some other issues I found:

• the guest user can upload files to his account, although the quota is set to 0. After some more tries I realized that this is only possible directly after activating the account. If I logout and login again, the upload is blocked correctly.
• After I logged in the second time the drop-down menu on the top right is broken so I can't logout anymore.
• For testing purpose I disabled the sharing app for the guest users. If they now open the sidebar and to to the sharing tab they see a spinner for ever.

[icewind1991]

• User listing is fixed
• I can't reproduce the "user is able to upload" or "drop down menu broken" but I pushed some changes to make the readonly restriction a bit more reliable.
• not sure if there is any real fix for the share problem, it's blocking the app "as expected"

[icewind1991]

• requires Add the option to filter mounts for a user server#10179

[schiessle]

I tested it again. The "user is able to upload" problem is gone.

This is how it looks after login, the gray button at the right looks strange es well

If I click it, it switches to the gallery view:

and now I have a gray button at the left, If I click it I see a upload action:

although the upload fails with "not enough free space" as expected

Another thing I noted, when I click on the nextcloud logo at the top left I get redirected correctly to domain/index.php but it will result in a error page:

Last but no least, if I click on the users avatar I see only a small error but the menu is gone:

I tried it with Firefox and Chromium, in incognito mode and also deleted the browser cache manually.

[wobben]

Sharing with a guest never finishes: "Creating guest account"

Exception":"Exception","Message":"Could not find category \"_$!<Favorite>!$_\"","Code":0,"Trace":[{"file":"\/lib\/private\/Tags.php","line":628,"function":"getIdsForTag","class":"OC\\Tags","type":"->","args":["_$!<Favorite>!$_"]},{"file":"\/apps\/files\/lib\/Activity\/Helper.php","line":51,"function":"getFavorites","class":"OC\\Tags","type":"->","args":[]},{"file":"\/apps\/files\/lib\/Controller\/ViewController.php","line":163,"function":"getFavoriteFilePaths","class":"OCA\\Files\\Activity\\Helper","type":"->","args":["admin"]},{"file":"\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":166,"function":"index","class":"OCA\\Files\\Controller\\ViewController","type":"->","args":["","",null,false]},{"file":"\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files\\Controller\\ViewController"},"index"]},{"file":"\/lib\/private\/AppFramework\/App.php","line":118,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files\\Controller\\ViewController"},"index"]},{"file":"\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["ViewController","index",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"files.view.index"}]},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->","args":[{"_route":"files.view.index"}]},{"file":"\/lib\/private\/Route\/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"},{"_route":"files.view.index"}]},{"file":"\/lib\/base.php","line":989,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/apps\/files\/"]},{"file":"\/index.php","line":42,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"\/lib\/private\/Tags.php","Line":282,"CustomMessage":"OC\\Tags::getFavorites"},"userAgent":"Mozilla\/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/68.0.3440.75 Safari\/537.36","version":"14.0.0.12"}

[weeman1337]

I updated the app.js where it hooks into the share auto complete. It now doesn't overwrite the entire methods any more and so it shouldn't break the default JS.

Nevertheless the guest dialog is still broken.

[icewind1991]

Fixed the problem with the dialog not appearing

[icewind1991]

@20XX @weeman1337 can you retest with the latest version of the PR

[wobben]

From a first test, it looks good, though the circle does not stop spinning when sharing with a new guest. Nevertheless, the temporary guest account is created.

[weeman1337]

It seems to work (NC-dev + this branch). 👍

[wobben]

@icewind1991 error with SSO/SAML configuration and default whitelisted apps:

With enabled SAML config, error when logging in as an activated guest user.
direct access to shared folder still works fine

[icewind1991]

Since this is otherwise unmaintained, I'll merge this and work from there