-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Nextcloud compatibility #1
Merged
Merged
Changes from 3 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
0b8529d
Mark compatible with 12
LukasReschke f8e909e
Use Nextcloud settings panel
LukasReschke 25a9571
Use TemplateResponse
LukasReschke 51d9b48
Use SHARE_TYPE_GUEST
LukasReschke e931baf
Mark compatible with 12
LukasReschke 7f1a6e0
Use Nextcloud settings panel
LukasReschke 9d9419a
Use TemplateResponse
LukasReschke a11c762
Use SHARE_TYPE_GUEST
LukasReschke 672ddf3
Use owncloud as appname
rullzer f0e0326
Merge branch 'make-compatible-with-nextcloud' of https://github.com/n…
LukasReschke 7b461bb
Merge branch 'master' into make-compatible-with-nextcloud
LukasReschke b6964bc
Use proper sidebar icon
LukasReschke 8c5781b
Fix intergration tests paths
rullzer 26c4d11
Get basic functionality working
icewind1991 4c1dff2
add always enabled guest apps to ensure minimal functionality
icewind1991 19e38bf
better whitelist configuration
icewind1991 2debade
more descriptive guest uid's and cleaner guest dialog
icewind1991 bb0100b
use displayname in email recipient
icewind1991 0a63a66
cache data should be writable
icewind1991 78f25aa
fix guest detection
icewind1991 2568838
better naming
icewind1991 43d3344
filter navigation entries that are blocked for the guest
icewind1991 6e755f0
proper navigation filtering
icewind1991 13ffc37
set activation links to never expire
icewind1991 8515fbb
use themed email for invitation
icewind1991 457c03a
share notifications for existing guests
icewind1991 bc6f62b
dont allow creating guests with an exising email
icewind1991 d0ff5ab
remove todo
icewind1991 8d7b3cb
fix webdav and merged js not being allowed
icewind1991 8daac06
enable in 13
icewind1991 13a5d31
mark compatible with 14
icewind1991 791fc01
make group id non configurable
icewind1991 9dcdfac
nc 14 compatibility
icewind1991 76dad15
fix readonly wrapper not getting applied
icewind1991 d8b4331
fix login
icewind1991 039a1fa
remove files external from default allowed apps
icewind1991 f09b3af
hide contacts menu for guests
icewind1991 91dec39
store guests in their own user backend.
icewind1991 5b3c876
generate userid serverside
icewind1991 88a8a2c
use raw email as userid
icewind1991 7e58d8a
give guests a 0b quota
icewind1991 3a9fbd8
fix logout button
icewind1991 e7bc2d6
Fix double mail
icewind1991 5c65830
guest dialog polish
icewind1991 b7f5bcc
makefile
icewind1991 eadae2f
prevent guests from creating more guests
icewind1991 8b31b77
fix non guests login
icewind1991 a70fbfb
allow creating guest account from email
icewind1991 9f5a2c2
fix user listing
icewind1991 36148ad
restrict filesystem access when using basic auth
icewind1991 702eb28
block external shares for guests by defailt
icewind1991 7c54f64
prevent files external error message
icewind1991 4f35fb0
fixes the share autocomplete js plugin. nextcloud/server#10114
weeman1337 f26d724
nc 15 compat
icewind1991 de8c56d
show error message on share
icewind1991 9137834
fix guest dialog not being visible
icewind1991 474e921
better email detection
icewind1991 16ab665
fix double entries in autocomplete
icewind1991 31a678e
add screenshots
icewind1991 33b99a3
update info.xml
icewind1991 8bc18f3
Fix 'index.php' being blocked by the whitelist
icewind1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
<?php | ||
/** | ||
* @copyright Copyright (c) 2017 Lukas Reschke <[email protected]> | ||
* | ||
* @author Lukas Reschke <[email protected]> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
namespace OCA\Guests\Settings; | ||
|
||
use OCP\IL10N; | ||
use OCP\IURLGenerator; | ||
use OCP\Settings\IIconSection; | ||
|
||
class Section implements IIconSection { | ||
/** @var IL10N */ | ||
private $l; | ||
/** @var IURLGenerator */ | ||
private $url; | ||
|
||
/** | ||
* @param IURLGenerator $url | ||
* @param IL10N $l | ||
*/ | ||
public function __construct(IURLGenerator $url, IL10N $l) { | ||
$this->url = $url; | ||
$this->l = $l; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getID() { | ||
return 'guests'; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getName() { | ||
return $this->l->t('Guests'); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getPriority() { | ||
return 30; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getIcon() { | ||
// TODO: Jan needs to create a proper icon | ||
return $this->url->imagePath('logreader', 'app-dark.svg'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jancborchardt Can you please create an icon? THX. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, see #13 :) |
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO can be removed :)