Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement federated group sharing #9895

Merged
merged 14 commits into from
Jul 11, 2018
Merged

implement federated group sharing #9895

merged 14 commits into from
Jul 11, 2018

Conversation

schiessle
Copy link
Member

@schiessle schiessle commented Jun 18, 2018

Allows you to share a file/folder with a group on a different server. The group is addressed similiar to a individual user: <groupname>@<server>. By default incoming and outgoing federated group shares are disabled in the admin settings.

  • send federated group share
  • individual user can accept share
  • individual user can decline share
  • individual user can unshare from self
  • handle unshare notification from owner correctly
  • handle permission change from owner correctly
  • UI to create federated group share

Fixes #4252

@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #9895 into master will decrease coverage by 45.08%.
The diff coverage is 1.44%.

@@             Coverage Diff              @@
##             master   #9895       +/-   ##
============================================
- Coverage      51.4%   6.32%   -45.09%     
- Complexity    26411   26448       +37     
============================================
  Files          1690    1690               
  Lines         97712   97836      +124     
  Branches       1292    1290        -2     
============================================
- Hits          50233    6184    -44049     
- Misses        47479   91652    +44173
Impacted Files Coverage Δ Complexity Δ
core/js/share.js 44.55% <ø> (ø) 0 <0> (ø) ⬇️
...dfilesharing/composer/composer/autoload_static.php 0% <ø> (ø) 1 <0> (ø) ⬇️
apps/cloud_federation_api/appinfo/app.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/cloud_federation_api/lib/Capabilities.php 0% <0%> (ø) 2 <2> (ø) ⬇️
...es_sharing/lib/Controller/ShareesAPIController.php 0% <0%> (-69.63%) 24 <2> (ø)
...s/federatedfilesharing/lib/AppInfo/Application.php 0% <0%> (-52.5%) 6 <1> (ø)
...ation/Exceptions/AuthenticationFailedException.php 0% <0%> (ø) 1 <1> (ø) ⬇️
apps/cloud_federation_api/lib/Config.php 0% <0%> (ø) 3 <3> (+1) ⬆️
lib/private/Federation/CloudFederationShare.php 0% <0%> (ø) 27 <27> (+2) ⬆️
...lesharing/lib/ocm/CloudFederationProviderFiles.php 0% <0%> (ø) 82 <82> (+8) ⬆️
... and 950 more

@schiessle schiessle force-pushed the fed-group-shares branch 2 times, most recently from 57beaba to a6430f6 Compare June 29, 2018 10:02
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jun 29, 2018
@MorrisJobke
Copy link
Member

@schiessle Could you rebase to resolve the conflicts and have less changes as the other PR got merged.

@schiessle
Copy link
Member Author

@MorrisJobke just done 🙂

@schiessle schiessle added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 4, 2018
@rullzer
Copy link
Member

rullzer commented Jul 5, 2018

I would feel a lot more comfortable if you could extend (or copy) the federated integration tests and move them to group shares. Just so we know when it does 💥

@schiessle
Copy link
Member Author

schiessle commented Jul 10, 2018

@rullzer I added some integration tests. Now it is your turn 😉

@rullzer
Copy link
Member

rullzer commented Jul 10, 2018

Now the unit tests fail ;)

@rullzer
Copy link
Member

rullzer commented Jul 10, 2018

And yay for tests!

Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
@schiessle
Copy link
Member Author

@rullzer unit tests should be fixed now

@MorrisJobke
Copy link
Member

Fixes #4252

I added this to the OP 😉

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay lets do this!

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit 3036b1d into master Jul 11, 2018
@MorrisJobke MorrisJobke deleted the fed-group-shares branch July 11, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants