Fix navigation icon bullet accessibility #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3960 +/- ##
============================================
+ Coverage 29.44% 29.45% +0.01%
Complexity 323 323
============================================
Files 221 220 -1
Lines 7580 7577 -3
Branches 1002 1002
============================================
Hits 2232 2232
+ Misses 5348 5345 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
is this ready for review? also, how to test it? |
JuliaKirschenheuter
force-pushed
the
fix/3955-visibility_toggle_is_not_focusable_via_keyboard
branch
from
1e06e2f
to
98e89ce
Compare
|
@nimishavijay now (with focus on circle): before (without focus on circle): |
|
fixes #3955 |
nimishavijay
approved these changes
Feb 17, 2022
ChristophWurst
changed the title
ChristophWurst
requested changes
Feb 23, 2022
use CheckboxBlankCircle as icon within the Action for icon bullet instead of AppNavigationIconBullet and AppNavigationDisabledCalendarIconBullet. AppNavigationDisabledCalendarIconBullet is not needed anymore. Signed-off-by: julia.kirschenheuter <[email protected]> !Fixup tabulation Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
force-pushed
the
fix/3955-visibility_toggle_is_not_focusable_via_keyboard
branch
from
98e89ce
to
b9576fc
Compare
ChristophWurst
approved these changes
Feb 23, 2022
delete-merged-branch
bot
deleted the
fix/3955-visibility_toggle_is_not_focusable_via_keyboard
branch
|
/backport to stable3.0 |
backportbot-nextcloud
bot
added
the
backport-request
backportbot-nextcloud
bot
removed
the
backport-request
|
/backport to stable3.1 |
backportbot-nextcloud
bot
added
the
backport-request
1 task
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use CheckboxBlankCircle as icon within the Action for icon bullet instead of AppNavigationIconBullet and AppNavigationDisabledCalendarIconBullet.
AppNavigationDisabledCalendarIconBullet is not needed anymore.
fixes #3955
fixes #3966