Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CheckboxBlankCircleOutline if calendar is disabled #4005

Closed
raimund-schluessler opened this issue Mar 1, 2022 · 1 comment · Fixed by #4010
Closed

Use CheckboxBlankCircleOutline if calendar is disabled #4005

raimund-schluessler opened this issue Mar 1, 2022 · 1 comment · Fixed by #4010
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to design, interface, interaction design, UX, etc. enhancement New feature request regression Regression of a previous working feature

Comments

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Mar 1, 2022

Is your feature request related to a problem? Please describe.

After #3960 when a calendar is disabled, only the color of the icon-bullet is changed to var(--color-text-lighter). This makes it not obvious that the calendar is disabled, because it's just a different color. If you happen to have calendars with a similar color, or have a color-impaired vision, you are a bit lost.
See here for example:
Screenshot 2022-03-01 at 09-52-36 Woche 9 aus 2022 - Kalender - Nextcloud

Describe the solution you'd like

Use a different icon for disabled calendars: CheckboxBlankCircleOutline here

<CheckboxBlankCircle
:title="calendar.enabled ? $t('calendar', 'Disable calendar') : $t('calendar', 'Enable calendar') "
:size="20"
:fill-color="calendar.enabled ? calendar.color : 'var(--color-text-lighter)'" />

This would solve the problem:
Screenshot 2022-03-01 at 09-54-22 Woche 9 aus 2022 - Kalender - Nextcloud

Describe alternatives you've considered

No response

Additional context

No response

@JuliaKirschenheuter @nimishavijay For the design here.

@raimund-schluessler raimund-schluessler added enhancement New feature request 0. to triage Pending approval or rejection design Related to design, interface, interaction design, UX, etc. regression Regression of a previous working feature labels Mar 1, 2022
@raimund-schluessler raimund-schluessler self-assigned this Mar 1, 2022
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 0. to triage Pending approval or rejection labels Mar 1, 2022
@raimund-schluessler raimund-schluessler added this to the v3.1.1 milestone Mar 1, 2022
@nimishavijay
Copy link
Member

Good point! Your solution would work great 🚀

@skjnldsv skjnldsv modified the milestones: v3.1.1, v3.2.1 Mar 10, 2022
@miaulalala miaulalala modified the milestone: v3.2.1 Mar 10, 2022
@miaulalala miaulalala removed this from the v3.2.1 milestone Mar 14, 2022
@miaulalala miaulalala added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to design, interface, interaction design, UX, etc. enhancement New feature request regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants